s1d3sw1ped/helix-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci/docker: Align Dockerfile and compose ports with README defaults #10

New Issue
Closed
opened 2026-09-02 11:19:45 -05:00 by Ghost · 1 comment
Ghost commented 2026-09-02 11:19:45 -05:00
Copy Link
Copy Source

Problem

README documents binary defaults admin 127.0.0.1:8081, proxy HTTP :8080, HTTPS :18443, and says those apply inside the container unless env overrides are set. The Docker example that uses 81/80/443 sets ADMIN_PORT / PROXY_* explicitly.

Shipped Docker files do not match that story:

  • Dockerfile still EXPOSE 80 81 443 (implies admin 81 without documenting required env).
  • docker-compose.yml healthcheck hits http://127.0.0.1:81/api but does not set ADMIN_PORT=81 (or the other port envs). With README defaults the admin listener is on 8081, so the healthcheck is wrong / flaky vs the documented binary defaults.

Do (Ash — one PR on develop)

Pick one consistent story and implement it (no redesign):

Option A (compose as published 80/81/443): set ADMIN_PORT=81, ADMIN_HOST=..., PROXY_HTTP_PORT=80, PROXY_HTTPS_PORT=443 in compose (and keep EXPOSE/healthcheck on 81). README docker-compose blurb must still be true.

Option B (compose follows binary defaults): change healthcheck / EXPOSE / any implied ports to 8081 / 8080 / 18443 and do not pretend 81 works without env.

Same-PR docs: touch README only if a line still lies after the file change. Do not invent a new port scheme.

Out of scope: UI redesign, auth changes, multi-admin, LICENSE.

Revert: git revert. No DB migration. Do not merge yourself. Subject like docker: Align compose healthcheck with admin port.

Next action

Ash implements. Ping Linus with the PR URL when up.

## Problem README documents binary defaults admin `127.0.0.1:8081`, proxy HTTP `:8080`, HTTPS `:18443`, and says those apply inside the container unless env overrides are set. The Docker example that uses `81/80/443` sets `ADMIN_PORT` / `PROXY_*` explicitly. Shipped Docker files do not match that story: - `Dockerfile` still `EXPOSE 80 81 443` (implies admin 81 without documenting required env). - `docker-compose.yml` healthcheck hits `http://127.0.0.1:81/api` but does **not** set `ADMIN_PORT=81` (or the other port envs). With README defaults the admin listener is on **8081**, so the healthcheck is wrong / flaky vs the documented binary defaults. ## Do (Ash — one PR on develop) Pick **one** consistent story and implement it (no redesign): **Option A (compose as published 80/81/443):** set `ADMIN_PORT=81`, `ADMIN_HOST=...`, `PROXY_HTTP_PORT=80`, `PROXY_HTTPS_PORT=443` in compose (and keep EXPOSE/healthcheck on 81). README docker-compose blurb must still be true. **Option B (compose follows binary defaults):** change healthcheck / EXPOSE / any implied ports to `8081` / `8080` / `18443` and do not pretend 81 works without env. Same-PR docs: touch README only if a line still lies after the file change. Do not invent a new port scheme. Out of scope: UI redesign, auth changes, multi-admin, LICENSE. Revert: `git revert`. No DB migration. Do not merge yourself. Subject like `docker: Align compose healthcheck with admin port`. ## Next action Ash implements. Ping Linus with the PR URL when up.
Ghost closed this issue 2026-09-02 11:31:39 -05:00
Ghost commented 2026-09-02 11:31:57 -05:00
Copy Link
Copy Source

Fixed by squash-merge of #11 (a6e069340902): compose env now sets 80/81/443 to match healthcheck/EXPOSE; README documents binary vs Docker ports.

Fixed by squash-merge of https://git.s1d3sw1ped.com/s1d3sw1ped/helix-proxy/pulls/11 (`a6e069340902`): compose env now sets 80/81/443 to match healthcheck/EXPOSE; README documents binary vs Docker ports.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/helix-proxy#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?