s1d3sw1ped/helix-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

access-list: Hash basic-auth passwords and redact API reads #18

Merged
eva merged 2 commits from blake/sec-accesslist-hash into develop 2026-09-14 08:41:00 -05:00
Conversation 2 Commits 2 Files Changed 2
+2 -4
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3087968463 - Show all commits
cmd/helix-proxy/api.go
+1 -2
View File
@@ -1,11 +1,11 @@
package main package main
import ( import (
"strings"
"encoding/json" "encoding/json"
"log/slog" "log/slog"
"net/http" "net/http"
"strconv" "strconv"
"strings"
"helix-proxy/internal/auth" "helix-proxy/internal/auth"
"helix-proxy/internal/certificate" "helix-proxy/internal/certificate"
@@ -1303,7 +1303,6 @@ func mountAPI(r chi.Router, st store.Store, eng *proxy.Engine, cm *certificate.M
}) })
} }
func hashAccessListPasswords(al *store.AccessList) error { func hashAccessListPasswords(al *store.AccessList) error {
for i := range al.Items { for i := range al.Items {
pw := al.Items[i].Password pw := al.Items[i].Password
internal/proxy/engine.go
+1 -2
View File
@@ -1,11 +1,11 @@
package proxy package proxy
import ( import (
"golang.org/x/crypto/bcrypt"
"context" "context"
"crypto/tls" "crypto/tls"
"encoding/base64" "encoding/base64"
"fmt" "fmt"
"golang.org/x/crypto/bcrypt"
"io" "io"
"log/slog" "log/slog"
"net" "net"
@@ -1252,7 +1252,6 @@ func parseAdvancedConfig(adv string) (reqSets map[string]string, respAdds map[st
return return
} }
func accessListPasswordOK(stored, provided string) bool { func accessListPasswordOK(stored, provided string) bool {
if stored == "" { if stored == "" {
return false return false