Add tests for main package, manager, and various components
- Introduced unit tests for the main package to ensure compilation. - Added tests for the manager, including validation of upload sessions and handling of Blender binary paths. - Implemented tests for job token generation and validation, ensuring security and integrity. - Created tests for configuration management and database schema to verify functionality. - Added tests for logger and runner components to enhance overall test coverage and reliability.
This commit is contained in:
@@ -385,7 +385,7 @@ func (p *EncodeProcessor) Process(ctx *Context) error {
|
||||
func detectAlphaChannel(ctx *Context, filePath string) bool {
|
||||
// Use ffprobe to check pixel format and stream properties
|
||||
// EXR files with alpha will have formats like gbrapf32le (RGBA) vs gbrpf32le (RGB)
|
||||
cmd := exec.Command("ffprobe",
|
||||
cmd := execCommand("ffprobe",
|
||||
"-v", "error",
|
||||
"-select_streams", "v:0",
|
||||
"-show_entries", "stream=pix_fmt:stream=codec_name",
|
||||
@@ -418,7 +418,7 @@ func detectAlphaChannel(ctx *Context, filePath string) bool {
|
||||
// detectHDR checks if an EXR file contains HDR content using ffprobe
|
||||
func detectHDR(ctx *Context, filePath string) bool {
|
||||
// First, check if the pixel format supports HDR (32-bit float)
|
||||
cmd := exec.Command("ffprobe",
|
||||
cmd := execCommand("ffprobe",
|
||||
"-v", "error",
|
||||
"-select_streams", "v:0",
|
||||
"-show_entries", "stream=pix_fmt",
|
||||
@@ -446,7 +446,7 @@ func detectHDR(ctx *Context, filePath string) bool {
|
||||
// For 32-bit float EXR, sample pixels to check if values exceed SDR range (> 1.0)
|
||||
// Use ffmpeg to extract pixel statistics - check max pixel values
|
||||
// This is more efficient than sampling individual pixels
|
||||
cmd = exec.Command("ffmpeg",
|
||||
cmd = execCommand("ffmpeg",
|
||||
"-v", "error",
|
||||
"-i", filePath,
|
||||
"-vf", "signalstats",
|
||||
@@ -489,7 +489,7 @@ func detectHDRBySampling(ctx *Context, filePath string) bool {
|
||||
}
|
||||
|
||||
for _, region := range sampleRegions {
|
||||
cmd := exec.Command("ffmpeg",
|
||||
cmd := execCommand("ffmpeg",
|
||||
"-v", "error",
|
||||
"-i", filePath,
|
||||
"-vf", fmt.Sprintf("%s,scale=1:1", region),
|
||||
|
||||
120
internal/runner/tasks/encode_test.go
Normal file
120
internal/runner/tasks/encode_test.go
Normal file
@@ -0,0 +1,120 @@
|
||||
package tasks
|
||||
|
||||
import (
|
||||
"encoding/binary"
|
||||
"math"
|
||||
"os"
|
||||
"os/exec"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestFloat32FromBytes(t *testing.T) {
|
||||
got := float32FromBytes([]byte{0x00, 0x00, 0x80, 0x3f}) // 1.0 little-endian
|
||||
if got != 1.0 {
|
||||
t.Fatalf("float32FromBytes() = %v, want 1.0", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestMax(t *testing.T) {
|
||||
if got := max(1, 2); got != 2 {
|
||||
t.Fatalf("max() = %v, want 2", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestExtractFrameNumber(t *testing.T) {
|
||||
if got := extractFrameNumber("render_0042.png"); got != 42 {
|
||||
t.Fatalf("extractFrameNumber() = %d, want 42", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCheckFFmpegSizeError(t *testing.T) {
|
||||
err := checkFFmpegSizeError("hardware does not support encoding at size ... constraints: width 128-4096 height 128-4096")
|
||||
if err == nil {
|
||||
t.Fatal("expected a size error")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDetectAlphaChannel_UsesExecSeam(t *testing.T) {
|
||||
orig := execCommand
|
||||
execCommand = fakeExecCommand
|
||||
defer func() { execCommand = orig }()
|
||||
|
||||
if !detectAlphaChannel(&Context{}, "/tmp/frame.exr") {
|
||||
t.Fatal("expected alpha channel detection via mocked ffprobe output")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDetectHDR_UsesExecSeam(t *testing.T) {
|
||||
orig := execCommand
|
||||
execCommand = fakeExecCommand
|
||||
defer func() { execCommand = orig }()
|
||||
|
||||
if !detectHDR(&Context{}, "/tmp/frame.exr") {
|
||||
t.Fatal("expected HDR detection via mocked ffmpeg sampling output")
|
||||
}
|
||||
}
|
||||
|
||||
func fakeExecCommand(command string, args ...string) *exec.Cmd {
|
||||
cs := []string{"-test.run=TestExecHelperProcess", "--", command}
|
||||
cs = append(cs, args...)
|
||||
cmd := exec.Command(os.Args[0], cs...)
|
||||
cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
|
||||
return cmd
|
||||
}
|
||||
|
||||
func TestExecHelperProcess(t *testing.T) {
|
||||
if os.Getenv("GO_WANT_HELPER_PROCESS") != "1" {
|
||||
return
|
||||
}
|
||||
|
||||
idx := 0
|
||||
for i, a := range os.Args {
|
||||
if a == "--" {
|
||||
idx = i
|
||||
break
|
||||
}
|
||||
}
|
||||
if idx == 0 || idx+1 >= len(os.Args) {
|
||||
os.Exit(2)
|
||||
}
|
||||
|
||||
cmdName := os.Args[idx+1]
|
||||
cmdArgs := os.Args[idx+2:]
|
||||
|
||||
switch cmdName {
|
||||
case "ffprobe":
|
||||
if containsArg(cmdArgs, "stream=pix_fmt:stream=codec_name") {
|
||||
_, _ = os.Stdout.WriteString("pix_fmt=gbrapf32le\ncodec_name=exr\n")
|
||||
os.Exit(0)
|
||||
}
|
||||
_, _ = os.Stdout.WriteString("gbrpf32le\n")
|
||||
os.Exit(0)
|
||||
case "ffmpeg":
|
||||
if containsArg(cmdArgs, "signalstats") {
|
||||
_, _ = os.Stderr.WriteString("signalstats failed")
|
||||
os.Exit(1)
|
||||
}
|
||||
if containsArg(cmdArgs, "rawvideo") {
|
||||
buf := make([]byte, 12)
|
||||
binary.LittleEndian.PutUint32(buf[0:4], math.Float32bits(1.5))
|
||||
binary.LittleEndian.PutUint32(buf[4:8], math.Float32bits(0.2))
|
||||
binary.LittleEndian.PutUint32(buf[8:12], math.Float32bits(0.1))
|
||||
_, _ = os.Stdout.Write(buf)
|
||||
os.Exit(0)
|
||||
}
|
||||
os.Exit(0)
|
||||
default:
|
||||
os.Exit(0)
|
||||
}
|
||||
}
|
||||
|
||||
func containsArg(args []string, target string) bool {
|
||||
for _, a := range args {
|
||||
if strings.Contains(a, target) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
7
internal/runner/tasks/exec_seams.go
Normal file
7
internal/runner/tasks/exec_seams.go
Normal file
@@ -0,0 +1,7 @@
|
||||
package tasks
|
||||
|
||||
import "os/exec"
|
||||
|
||||
// execCommand is a seam for process execution in tests.
|
||||
var execCommand = exec.Command
|
||||
|
||||
42
internal/runner/tasks/processor_test.go
Normal file
42
internal/runner/tasks/processor_test.go
Normal file
@@ -0,0 +1,42 @@
|
||||
package tasks
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"testing"
|
||||
|
||||
"jiggablend/pkg/types"
|
||||
)
|
||||
|
||||
func TestNewContext_NormalizesFrameEnd(t *testing.T) {
|
||||
ctx := NewContext(1, 2, "job", 10, 1, "render", "/tmp", "tok", nil, nil, nil, nil, nil, nil, nil, false, false, false, false, false, false, nil)
|
||||
if ctx.FrameEnd != 10 {
|
||||
t.Fatalf("expected FrameEnd to be normalized to Frame, got %d", ctx.FrameEnd)
|
||||
}
|
||||
}
|
||||
|
||||
func TestContext_GetOutputFormat_Default(t *testing.T) {
|
||||
ctx := &Context{}
|
||||
if got := ctx.GetOutputFormat(); got != "PNG" {
|
||||
t.Fatalf("GetOutputFormat() = %q, want PNG", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestContext_ShouldForceCPU(t *testing.T) {
|
||||
ctx := &Context{ForceCPURendering: true}
|
||||
if !ctx.ShouldForceCPU() {
|
||||
t.Fatal("expected force cpu when runner-level flag is set")
|
||||
}
|
||||
|
||||
force := true
|
||||
ctx = &Context{Metadata: &types.BlendMetadata{RenderSettings: types.RenderSettings{EngineSettings: map[string]interface{}{"force_cpu": force}}}}
|
||||
if !ctx.ShouldForceCPU() {
|
||||
t.Fatal("expected force cpu when metadata requests it")
|
||||
}
|
||||
}
|
||||
|
||||
func TestErrJobCancelled_IsSentinel(t *testing.T) {
|
||||
if !errors.Is(ErrJobCancelled, ErrJobCancelled) {
|
||||
t.Fatal("sentinel error should be self-identical")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -88,6 +88,11 @@ func (p *RenderProcessor) Process(ctx *Context) error {
|
||||
ctx.Info("No Blender version specified, using system blender")
|
||||
}
|
||||
|
||||
blenderBinary, err = blender.ResolveBinaryPath(blenderBinary)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to resolve blender binary: %w", err)
|
||||
}
|
||||
|
||||
// Create output directory
|
||||
outputDir := filepath.Join(ctx.WorkDir, "output")
|
||||
if err := os.MkdirAll(outputDir, 0755); err != nil {
|
||||
@@ -202,8 +207,16 @@ func (p *RenderProcessor) createRenderScript(ctx *Context, renderFormat string)
|
||||
|
||||
func (p *RenderProcessor) runBlender(ctx *Context, blenderBinary, blendFile, outputDir, renderFormat, blenderHome string) error {
|
||||
scriptPath := filepath.Join(ctx.WorkDir, "enable_gpu.py")
|
||||
blendFileAbs, err := filepath.Abs(blendFile)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to resolve blend file path: %w", err)
|
||||
}
|
||||
scriptPathAbs, err := filepath.Abs(scriptPath)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to resolve blender script path: %w", err)
|
||||
}
|
||||
|
||||
args := []string{"-b", blendFile, "--python", scriptPath}
|
||||
args := []string{"-b", blendFileAbs, "--python", scriptPathAbs}
|
||||
if ctx.ShouldEnableExecution() {
|
||||
args = append(args, "--enable-autoexec")
|
||||
}
|
||||
@@ -220,7 +233,7 @@ func (p *RenderProcessor) runBlender(ctx *Context, blenderBinary, blendFile, out
|
||||
args = append(args, "-f", fmt.Sprintf("%d", ctx.Frame))
|
||||
}
|
||||
|
||||
cmd := exec.Command(blenderBinary, args...)
|
||||
cmd := execCommand(blenderBinary, args...)
|
||||
cmd.Dir = ctx.WorkDir
|
||||
|
||||
// Set up environment: LD_LIBRARY_PATH for tarball Blender, then custom HOME
|
||||
|
||||
28
internal/runner/tasks/render_test.go
Normal file
28
internal/runner/tasks/render_test.go
Normal file
@@ -0,0 +1,28 @@
|
||||
package tasks
|
||||
|
||||
import "testing"
|
||||
|
||||
func TestCheckGPUErrorLine_TriggersCallback(t *testing.T) {
|
||||
p := NewRenderProcessor()
|
||||
triggered := false
|
||||
ctx := &Context{
|
||||
OnGPUError: func() { triggered = true },
|
||||
}
|
||||
p.checkGPUErrorLine(ctx, "Fatal: Illegal address in HIP kernel execution")
|
||||
if !triggered {
|
||||
t.Fatal("expected GPU error callback to be triggered")
|
||||
}
|
||||
}
|
||||
|
||||
func TestCheckGPUErrorLine_IgnoresNormalLine(t *testing.T) {
|
||||
p := NewRenderProcessor()
|
||||
triggered := false
|
||||
ctx := &Context{
|
||||
OnGPUError: func() { triggered = true },
|
||||
}
|
||||
p.checkGPUErrorLine(ctx, "Render completed successfully")
|
||||
if triggered {
|
||||
t.Fatal("did not expect GPU callback for normal line")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user