build: Pin GoReleaser and stop the build on a toolchain mismatch #17

New issue

Closed

opened 2026-10-10 21:47:01 +00:00 by mira · 0 comments

mira commented

2026-10-10 21:47:01 +00:00

Collaborator

make build (Makefile:4-6) runs whatever goreleaser is on PATH, and the release job uses goreleaser/goreleaser-action@master with version: 'latest' (.gitea/workflows/release-tag.yaml:20-23) and actions/setup-go@main (release-tag.yaml:17). A release can come out of a different GoReleaser than any local build, and an upstream change on master can break a tag with no change on our side.

Justin's forge rule (2026-10-10): any toolchain that can only have one version installed at a time gets a preflight in the build. On a mismatch the build stops before doing anything, says what it found and what's required, and prints the exact fix. Standard and snippets: https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/src/branch/master/forge-toolchain.md (preflight script: https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/raw/branch/master/check-toolchain.sh). It follows the design in s1d3sw1ped/AI-Phone#322.

What to do

Make build depend on check-toolchain (snippet, with GORELEASER_VERSION ?= v2.18.3).
The preflight also fails if go.mod's go, toolchain or wails lines differ from HEAD (a silent rewrite), when the repo has a go.mod.
Add a line to the README's build section: what's checked and how to fix a mismatch.

Align with the forge standard in the same PR (all patch/minor or CI-only):

Add toolchain go1.27.2 under the go 1.27.0 line in go.mod (go.mod:3), so everyone builds on the same patch release and Go fetches it if the local one is older.
release-tag.yaml: goreleaser-action @master to @v6, version: v2.18.3, setup-go @main to @v5.

Acceptance

With a mismatched toolchain, the build stops before doing any work and prints found, required and the fix command. Nothing in the tree changes (git status is clean).
With the right toolchain, every build target works as before.
Editing a pinned go.mod line away from HEAD is caught.
CI passes and runs the preflight.

Out of scope

Major bumps of the CI actions (setup-go v7, setup-node v7, checkout v7, goreleaser-action v7, golangci-lint-action v9): stay on the current standard here; they're being piloted in s1d3sw1ped/vulture#17 first. Node stays on 24 (recheck in November, after 26 becomes LTS on 2026-10-28).

Handoff

One PR against the default branch. Ask Eva for review and don't merge it yourself. If it gets in the way, git revert the merge; nothing else to undo. Line refs are the default branch at 8d10cde.

Model: Gemma 26B censored.

`make build` (Makefile:4-6) runs whatever `goreleaser` is on PATH, and the release job uses `goreleaser/goreleaser-action@master` with `version: 'latest'` (.gitea/workflows/release-tag.yaml:20-23) and `actions/setup-go@main` (release-tag.yaml:17). A release can come out of a different GoReleaser than any local build, and an upstream change on master can break a tag with no change on our side. Justin's forge rule (2026-10-10): any toolchain that can only have one version installed at a time gets a preflight in the build. On a mismatch the build stops before doing anything, says what it found and what's required, and prints the exact fix. Standard and snippets: https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/src/branch/master/forge-toolchain.md (preflight script: https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/raw/branch/master/check-toolchain.sh). It follows the design in s1d3sw1ped/AI-Phone#322. ## What to do - Make `build` depend on `check-toolchain` (snippet, with `GORELEASER_VERSION ?= v2.18.3`). - The preflight also fails if go.mod's go, toolchain or wails lines differ from HEAD (a silent rewrite), when the repo has a go.mod. - Add a line to the README's build section: what's checked and how to fix a mismatch. Align with the forge standard in the same PR (all patch/minor or CI-only): - Add `toolchain go1.27.2` under the `go 1.27.0` line in go.mod (go.mod:3), so everyone builds on the same patch release and Go fetches it if the local one is older. - release-tag.yaml: goreleaser-action `@master` to `@v6`, `version: v2.18.3`, setup-go `@main` to `@v5`. ## Acceptance - [ ] With a mismatched toolchain, the build stops before doing any work and prints found, required and the fix command. Nothing in the tree changes (`git status` is clean). - [ ] With the right toolchain, every build target works as before. - [ ] Editing a pinned go.mod line away from HEAD is caught. - [ ] CI passes and runs the preflight. ## Out of scope Major bumps of the CI actions (setup-go v7, setup-node v7, checkout v7, goreleaser-action v7, golangci-lint-action v9): stay on the current standard here; they're being piloted in s1d3sw1ped/vulture#17 first. Node stays on 24 (recheck in November, after 26 becomes LTS on 2026-10-28). ## Handoff One PR against the default branch. Ask Eva for review and don't merge it yourself. If it gets in the way, git revert the merge; nothing else to undo. Line refs are the default branch at 8d10cde. Model: Gemma 26B censored.

mira added the

Kind/Enhancement

label

2026-10-10 21:47:01 +00:00