Web UI: vendor htmx locally instead of loading from unpkg.com (jobs page stuck on "Loading jobs...") #23
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
blocked
draft
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
s1d3sw1ped/jiggablend#23
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The manager's templates load htmx from a CDN:
<script src="https://unpkg.com/htmx.org@1.9.12"></script>. If the browser blocks third-party scripts (Brave Shields, uBlock, an offline/LAN-only box), htmx never loads, sohx-get="/ui/fragments/jobs"never fires and the Jobs page sits on "Loading jobs..." forever. Seen live on 0.0.10 (Justin, Brave). The API is fine:/api/jobsand/ui/fragments/jobsboth return 200 with the job.Fix
/assets/htmx.min.js) and point every template at the local copy. No external script/CSS hosts at all.https://script or style sources.Done when: the Jobs page lists jobs with all third-party requests blocked, and a release is tagged.
Reported by Jerry for Justin; urgent (Justin asked for a quick fix).
Urgent, Justin wants a quick fix. Scope: vendor htmx 1.9.12 into the embedded assets, point every template at the local copy, and add a test that rendered templates have no external (https://) script or style sources. Keep the toolchain preflight as is (forge-toolchain standard). Out of scope: any other UI changes. Revert is a plain git revert. Open the PR against develop (master if the repo has no develop) and don't merge it yourself; the 0.0.11 cut happens after it lands. Done when the Jobs page lists jobs with all third-party requests blocked.