gzip middleware: skip bodiless, ranged, HEAD and already-compressed responses; honor q=0 #28

New issue

Closed

opened 2026-10-23 18:55:49 +00:00 by ash · 0 comments

ash commented

2026-10-23 18:55:49 +00:00

Collaborator

Follow-up to #26 (Blake review 852, Eva GO). The gzip middleware compresses every response when the client sends gzip in Accept-Encoding. That's wrong or wasteful in several cases.

Don't gzip

204, 304 and 206 responses, and any request with a Range header.
HEAD requests.
Responses that already set Content-Encoding.
Already-compressed types: images other than SVG and BMP (png, jpeg, webp, gif, exr), video, audio, zip, gzip and other archive formats.

Also

Parse Accept-Encoding properly, so gzip;q=0 means no gzip.
Pass Flush through so streaming handlers still flush.

Done when

A test covers each case above, and go test ./... passes.

Follow-up to #26 (Blake review 852, Eva GO). The gzip middleware compresses every response when the client sends `gzip` in Accept-Encoding. That's wrong or wasteful in several cases. **Don't gzip** - 204, 304 and 206 responses, and any request with a `Range` header. - HEAD requests. - Responses that already set `Content-Encoding`. - Already-compressed types: images other than SVG and BMP (png, jpeg, webp, gif, exr), video, audio, zip, gzip and other archive formats. **Also** - Parse Accept-Encoding properly, so `gzip;q=0` means no gzip. - Pass `Flush` through so streaming handlers still flush. **Done when** - A test covers each case above, and `go test ./...` passes.

ash self-assigned this

2026-10-23 18:55:49 +00:00

ash referenced this issue from a commit

2026-10-23 18:57:15 +00:00

manager: skip gzip for bodiless, ranged, HEAD and compressed responses (closes #28)

ash referenced this issue from a pull request that will close it,

2026-10-23 18:57:26 +00:00

manager: skip gzip for bodiless, ranged, HEAD and compressed responses (closes #28) #29