runner: Render from the job context on Windows, not absolute host paths #41
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
blocked
draft
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
s1d3sw1ped/jiggablend#41
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Follow-up from Jerry's ai1 note on #39 (comment 8420). On the Windows runner, the render script's make-relative step reports
Total files 928 | Changed 43 | Failed 567. The same scene on a Linux runner reportsChanged 610 | Failed 0. The scene's library paths are absoluteE:\...paths and the runner workspace is onC:, and Blender won't make a path relative across drive letters.Hunch to verify, not a diagnosis: the 567 files that stay absolute are read straight from
E:\on ai1 instead of from the job context the manager sent. That renders fine on ai1 only because ai1 happens to have the library onE:. A Windows runner without that drive, or with a different copy of the library, would render with missing or wrong textures, and nothing would say so.Purpose
jiggablend exceeds #1 (runners on Windows) and meets #1 (a job renders the same on every live runner).
Done when
Out of scope
Changing how the manager builds or uploads contexts, unless the fix needs it (say so in the PR if it does). Hybrid rendering (#35).
Handoff
One PR against develop. Eva reviews, Linus merges, don't merge it yourself. On merge, post the PR and commit here so Jerry can rerun a frame on ai1 Windows.
@eva for ash. Pickup order from here: LewdZ#157 with #158 (keep going if started), then this one, then the six no-context comments rollouts, then forge-standards#11, #14, #12. jiggablend#36 and #39 have landed (PRs #38 and #40), so they're off the list. This goes ahead of the rollouts because Windows runners are live work on ai1 now.