s1d3sw1ped/robinhood-agentic-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

auth: Ignore tokens.json so Login output is not git-added #20

New Issue
Closed
opened 2026-09-14 08:23:44 -05:00 by blake · 1 comment
blake commented 2026-09-14 08:23:44 -05:00
Collaborator
Copy Link
Copy Source

Severity

Medium

What

Login / WriteTokens persist OAuth material at tokens.json (mode 0600), including access_token, refresh_token, and often client_secret. The repo .gitignore does not list tokens.json, so a normal git add . after a local login can stage live brokerage credentials.

tradey already ignores tokens.json; this library is the writer and the more likely place someone runs Login in-tree.

Practical impact

Accidental commit of Robinhood Agentic tokens to a public (or shared) forge clone enables account takeover / live order placement. Mode 0600 only helps on the local FS, not once the file is in git history.

Fix

Add tokens.json (and common variants if any) to .gitignore. Optionally mention the ignore in README next to the existing mode-0600 note.

Out of scope

Changing token format, OAuth flow, or live trading gates.

## Severity Medium ## What `Login` / `WriteTokens` persist OAuth material at `tokens.json` (mode 0600), including `access_token`, `refresh_token`, and often `client_secret`. The repo `.gitignore` does not list `tokens.json`, so a normal `git add .` after a local login can stage live brokerage credentials. `tradey` already ignores `tokens.json`; this library is the writer and the more likely place someone runs `Login` in-tree. ## Practical impact Accidental commit of Robinhood Agentic tokens to a public (or shared) forge clone enables account takeover / live order placement. Mode 0600 only helps on the local FS, not once the file is in git history. ## Fix Add `tokens.json` (and common variants if any) to `.gitignore`. Optionally mention the ignore in README next to the existing mode-0600 note. ## Out of scope Changing token format, OAuth flow, or live trading gates.
blake commented 2026-09-14 08:25:44 -05:00
Author
Collaborator
Copy Link
Copy Source

Fix PR: #21

Fix PR: https://git.s1d3sw1ped.com/s1d3sw1ped/robinhood-agentic-mcp/pulls/21
eva closed this issue 2026-09-14 08:30:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/robinhood-agentic-mcp#20
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?