ci: Add the no-context comments check #17

New issue

Open

opened 2026-10-30 23:29:11 +00:00 by mira · 0 comments

mira commented

2026-10-30 23:29:11 +00:00

Collaborator

Problem

Roll out the forge comments flow (https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/src/branch/master/comments.md, from forge-standards#8) to scratchbox. The LewdZ pilot (LewdZ#151, #153, #155) is live, and Justin accepted its comments on 2026-10-30.

Scope

Copy the checker and workflow from forge-standards master into this repo, following the snippet in comments.md: scripts/check-comments.py and .forgejo/workflows/comments.yml (permissions: contents: read).
Check only lines a PR adds. Existing comments must not fail.
After CI is green, Eva launches the no-context commenter pass (fresh headless run, head files only), which pushes one comments: no-context pass commit before Linus reviews.

Acceptance criteria

comments.yml runs on every PR, and the current develop tip passes unchanged.
A coder commit that adds a plain explanatory comment fails, and the log names the file and line. A commit that adds only an upstream link or license text passes.
A comments: no-context pass commit that changes a code line fails; one that only adds comments passes.
The PR links one red run and one green run.
The checker matches forge-standards master byte for byte, so nothing is forked.

Out of scope

Removing or rewriting existing comments: that's held until every repo's rollout merges. Other CI changes.

Purpose

scratchbox exceeds (quality): forge quality rules are enforced by CI.

Revert: git revert. Do not merge yourself; Eva and Blake (CI) review, Linus merges.

## Problem Roll out the forge comments flow (https://git.s1d3sw1ped.com/s1d3sw1ped/forge-standards/src/branch/master/comments.md, from forge-standards#8) to scratchbox. The LewdZ pilot (LewdZ#151, #153, #155) is live, and Justin accepted its comments on 2026-10-30. ## Scope - Copy the checker and workflow from forge-standards master into this repo, following the snippet in `comments.md`: `scripts/check-comments.py` and `.forgejo/workflows/comments.yml` (`permissions: contents: read`). - Check only lines a PR adds. Existing comments must not fail. - After CI is green, Eva launches the no-context commenter pass (fresh headless run, head files only), which pushes one `comments: no-context pass` commit before Linus reviews. ## Acceptance criteria - `comments.yml` runs on every PR, and the current develop tip passes unchanged. - A coder commit that adds a plain explanatory comment fails, and the log names the file and line. A commit that adds only an upstream link or license text passes. - A `comments: no-context pass` commit that changes a code line fails; one that only adds comments passes. - The PR links one red run and one green run. - The checker matches forge-standards master byte for byte, so nothing is forked. ## Out of scope Removing or rewriting existing comments: that's held until every repo's rollout merges. Other CI changes. ## Purpose scratchbox exceeds (quality): forge quality rules are enforced by CI. Revert: `git revert`. Do not merge yourself; Eva and Blake (CI) review, Linus merges.