refactor: moved the GC stuff around and corrected all tests

vfs/memory/memory_test.go

@@ -2,71 +2,92 @@
 package memory
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"s1d3sw1ped/SteamCache2/vfs/vfserror"
 	"testing"
 )
 
-func TestAllMemory(t *testing.T) {
-	t.Parallel()
-
+func TestCreateAndOpen(t *testing.T) {
 	m := New(1024)
-	w, err := m.Create("key", 5)
+	key := "key"
+	value := []byte("value")
+
+	w, err := m.Create(key, int64(len(value)))
 	if err != nil {
-		t.Errorf("Create failed: %v", err)
+		t.Fatalf("Create failed: %v", err)
 	}
-	w.Write([]byte("value"))
+	w.Write(value)
 	w.Close()
 
-	w, err = m.Create("key", 6)
+	rc, err := m.Open(key)
 	if err != nil {
-		t.Errorf("Create failed: %v", err)
+		t.Fatalf("Open failed: %v", err)
 	}
-	w.Write([]byte("value1"))
-	w.Close()
-
-	rc, err := m.Open("key")
-	if err != nil {
-		t.Errorf("Open failed: %v", err)
-	}
-	d, _ := io.ReadAll(rc)
+	got, _ := io.ReadAll(rc)
 	rc.Close()
-	if string(d) != "value1" {
-		t.Errorf("Get failed: got %s, want %s", d, "value1")
-	}
 
-	if err := m.Delete("key"); err != nil {
-		t.Errorf("Delete failed: %v", err)
-	}
-
-	if _, err := m.Open("key"); err == nil {
-		t.Errorf("Open failed: got nil, want %v", vfserror.ErrNotFound)
-	}
-
-	if err := m.Delete("key"); err == nil {
-		t.Errorf("Delete failed: got nil, want %v", vfserror.ErrNotFound)
-	}
-
-	if _, err := m.Stat("key"); err == nil {
-		t.Errorf("Stat failed: got nil, want %v", vfserror.ErrNotFound)
-	}
-
-	w, err = m.Create("key", 5)
-	if err != nil {
-		t.Errorf("Create failed: %v", err)
-	}
-	w.Write([]byte("value"))
-	w.Close()
-
-	if _, err := m.Stat("key"); err != nil {
-		t.Errorf("Stat failed: %v", err)
+	if string(got) != string(value) {
+		t.Fatalf("expected %s, got %s", value, got)
 	}
 }
 
-func TestLimited(t *testing.T) {
-	t.Parallel()
+func TestOverwrite(t *testing.T) {
+	m := New(1024)
+	key := "key"
+	value1 := []byte("value1")
+	value2 := []byte("value2")
 
+	w, err := m.Create(key, int64(len(value1)))
+	if err != nil {
+		t.Fatalf("Create failed: %v", err)
+	}
+	w.Write(value1)
+	w.Close()
+
+	w, err = m.Create(key, int64(len(value2)))
+	if err != nil {
+		t.Fatalf("Create failed: %v", err)
+	}
+	w.Write(value2)
+	w.Close()
+
+	rc, err := m.Open(key)
+	if err != nil {
+		t.Fatalf("Open failed: %v", err)
+	}
+	got, _ := io.ReadAll(rc)
+	rc.Close()
+
+	if string(got) != string(value2) {
+		t.Fatalf("expected %s, got %s", value2, got)
+	}
+}
+
+func TestDelete(t *testing.T) {
+	m := New(1024)
+	key := "key"
+	value := []byte("value")
+
+	w, err := m.Create(key, int64(len(value)))
+	if err != nil {
+		t.Fatalf("Create failed: %v", err)
+	}
+	w.Write(value)
+	w.Close()
+
+	if err := m.Delete(key); err != nil {
+		t.Fatalf("Delete failed: %v", err)
+	}
+
+	_, err = m.Open(key)
+	if !errors.Is(err, vfserror.ErrNotFound) {
+		t.Fatalf("expected %v, got %v", vfserror.ErrNotFound, err)
+	}
+}
+
+func TestCapacityLimit(t *testing.T) {
 	m := New(10)
 	for i := 0; i < 11; i++ {
 		w, err := m.Create(fmt.Sprintf("key%d", i), 1)
@@ -81,3 +102,28 @@ func TestLimited(t *testing.T) {
 		}
 	}
 }
+
+func TestStat(t *testing.T) {
+	m := New(1024)
+	key := "key"
+	value := []byte("value")
+
+	w, err := m.Create(key, int64(len(value)))
+	if err != nil {
+		t.Fatalf("Create failed: %v", err)
+	}
+	w.Write(value)
+	w.Close()
+
+	info, err := m.Stat(key)
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	if info == nil {
+		t.Fatal("expected file info to be non-nil")
+	}
+	if info.Size() != int64(len(value)) {
+		t.Errorf("expected size %d, got %d", len(value), info.Size())
+	}
+}