vfs/cache: Fix TestTieredCache_Concurrent data race with promoteToFast #21

New Issue

2026-09-01T15:24:40-05:00

Ghost commented

2026-09-01 15:24:40 -05:00

Problem

main tip a2ac13d317d6 (merge of disk insertBatch fix via #19/#20) fails CI run 1152 under go test -race in vfs/cache.

Disk package is green. This is a separate race.

Failure (CI #1152)

TestTieredCache_Concurrent — DATA RACE
TestTieredCache_PromotionFallback — race detected (likely cross-talk / same root)

Race report sketch:

Write vfs/memory.(*memoryWriteCloser).Close at memory.go:178 from test goroutine cache_test.go:117 (TestTieredCache_Concurrent.func1)
Read (*TieredCache).promoteToFast at cache.go:194 from Open background promote (cache.go:85)

So promote reads memory buffer/state while a writer Close mutates it (or the reverse: concurrent Close vs promote copy).

Wanted

Fix the real race in TieredCache promote path (and/or memory WriteCloser lifetime) so Close cannot race promoteToFast.
Keep go test -race green for ./vfs/cache (and full ./...).
Proof: go test -race -count=20 -shuffle=on ./vfs/cache locally green.
PR base develop. Commit style area: Imperative summary. Do not merge yourself.
Do not put #21 in the PR body (Gitea closes issues on any #N in merge text). Link this issue with a full URL if you mention it.

Out of scope

disk insertBatch / #18 (already fixed and on main)
CI markdown paths-ignore churn unless needed

Revert

Normal git revert of the PR commit(s). No DB.

## Problem `main` tip `a2ac13d317d6` (merge of disk insertBatch fix via #19/#20) fails CI run 1152 under `go test -race` in `vfs/cache`. Disk package is green. This is a separate race. ## Failure (CI #1152) - `TestTieredCache_Concurrent` — DATA RACE - `TestTieredCache_PromotionFallback` — race detected (likely cross-talk / same root) Race report sketch: - **Write** `vfs/memory.(*memoryWriteCloser).Close` at `memory.go:178` from test goroutine `cache_test.go:117` (`TestTieredCache_Concurrent.func1`) - **Read** `(*TieredCache).promoteToFast` at `cache.go:194` from `Open` background promote (`cache.go:85`) So promote reads memory buffer/state while a writer Close mutates it (or the reverse: concurrent Close vs promote copy). ## Wanted 1. Fix the real race in `TieredCache` promote path (and/or memory WriteCloser lifetime) so Close cannot race promoteToFast. 2. Keep `go test -race` green for `./vfs/cache` (and full `./...`). 3. Proof: `go test -race -count=20 -shuffle=on ./vfs/cache` locally green. 4. PR base `develop`. Commit style `area: Imperative summary`. Do **not** merge yourself. 5. Do **not** put `#21` in the PR body (Gitea closes issues on any `#N` in merge text). Link this issue with a full URL if you mention it. ## Out of scope - disk insertBatch / #18 (already fixed and on main) - CI markdown paths-ignore churn unless needed ## Revert Normal `git revert` of the PR commit(s). No DB.

Ghost referenced this issue

2026-09-01 15:25:16 -05:00

vfs/cache: Fix data race between memoryWriteCloser.Close and promoteToFast #22

Ghost commented

2026-09-01 15:25:17 -05:00

Next action: Ash owns one PR (develop → then main). Main tip red on CI run 1152 (TestTieredCache_Concurrent Close vs promoteToFast race). Prove with go test -race -count=20 -shuffle=on ./vfs/cache. Do not merge yourself.

Next action: Ash owns one PR (develop → then main). Main tip red on CI run 1152 (`TestTieredCache_Concurrent` Close vs `promoteToFast` race). Prove with `go test -race -count=20 -shuffle=on ./vfs/cache`. Do not merge yourself.

Ghost referenced this issue from a commit

2026-09-01 15:32:09 -05:00

vfs/cache: Fix promoteToFast race with WriteCloser Close

Ghost referenced this issue

2026-09-01 15:32:09 -05:00

vfs/cache: Fix promoteToFast race with WriteCloser Close #23

Ghost referenced this issue from a commit

2026-09-01 15:35:20 -05:00

Merge pull request 'vfs/cache: Fix promoteToFast race with WriteCloser Close' (#23) from vfs/cache-promote-race into develop

Ghost closed this issue

2026-09-01 15:35:55 -05:00

Ghost referenced this issue