ops: Signal disk-tier attach pending vs ready #45

Merged

linus merged 1 commit from ops/disk-tier-attach-signal into develop

2026-09-07 17:02:10 +00:00

Ghost commented

2026-09-07 16:58:47 +00:00

Why

Large disk caches can look memory-only/broken for seconds–minutes at startup while the disk tier attaches. That warm-up is intentional but opaque — operators should not need to read source to see attach pending vs ready.

What

disk_tier_ready gauge (0 pending / 1 ready, or 1 when no disk = N/A not waiting) in /metrics via existing WriteText
Info logs: attach pending at start + attached when SetSlow completes (disk-only and mixed)
/lancache-heartbeat header X-SteamCache-Disk-Tier: pending|ready|disabled
GetMetrics skips blocking disk.Size() while attach pending so /metrics stays responsive
README Quick check + Large Cache Initialization notes

How tested

go test ./steamcache/ -count=1 (PASS)
Focused: TestDiskOnlyDelayedAttach, TestDiskTierSignalMemoryOnly, TestDiskTierSignalMixedPendingReady
Review-labels grep (check-review-labels recipe) clean

Risks

Low: additive metrics/header/logs; attach path semantics unchanged
During pending, disk_cache_size in metrics may stay at last/zero until ready (by design — avoids hang)

Rollback

Revert this PR / merge revert commit.

Closes #33

## Why Large disk caches can look memory-only/broken for seconds–minutes at startup while the disk tier attaches. That warm-up is intentional but opaque — operators should not need to read source to see attach pending vs ready. ## What - `disk_tier_ready` gauge (`0` pending / `1` ready, or `1` when no disk = N/A not waiting) in `/metrics` via existing WriteText - Info logs: attach pending at start + attached when SetSlow completes (disk-only and mixed) - `/lancache-heartbeat` header `X-SteamCache-Disk-Tier: pending|ready|disabled` - `GetMetrics` skips blocking `disk.Size()` while attach pending so `/metrics` stays responsive - README Quick check + Large Cache Initialization notes ## How tested - `go test ./steamcache/ -count=1` (PASS) - Focused: `TestDiskOnlyDelayedAttach`, `TestDiskTierSignalMemoryOnly`, `TestDiskTierSignalMixedPendingReady` - Review-labels grep (check-review-labels recipe) clean ## Risks - Low: additive metrics/header/logs; attach path semantics unchanged - During pending, `disk_cache_size` in metrics may stay at last/zero until ready (by design — avoids hang) ## Rollback Revert this PR / merge revert commit. Closes #33

eva was assigned by Ghost

2026-09-07 16:58:47 +00:00

Ghost added 1 commit

2026-09-07 16:58:47 +00:00

ops: Signal disk-tier attach pending vs ready

CI / vulncheck (pull_request) Successful in 14s

Details

CI / check-and-test (pull_request) Successful in 40s

Details

12ea3ee4f6

Large disk caches can look memory-only/broken during async DiskFS attach.
Expose disk_tier_ready in /metrics, pending/ready logs for disk-only and
mixed modes, and X-SteamCache-Disk-Tier on /lancache-heartbeat. GetMetrics
skips blocking disk.Size() while attach is pending so /metrics stays usable.

Closes #33

Ghost requested review from eva

2026-09-07 16:58:47 +00:00