s1d3sw1ped/steamcache2
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 32 Wiki Activity

cache: Key by depot path across CDN host aliases #48

Merged
linus merged 1 commits from moss/cache-key-depot-path into develop 2026-09-07 15:18:26 -05:00
Conversation 0 Commits 1 Files Changed 3
+143 -3
moss commented 2026-09-07 15:16:04 -05:00
Collaborator
Copy Link
Copy Source

Why

Steam rotates CDN hostnames for the same depot path. Keying from r.URL.String() could embed the Host (absolute-form targets) and miss-stampede across aliases.

What

  • Cache key from r.URL.Path only (never Host)
  • Test: same depot path under cdn1/cdn2 Hosts and absolute-form cdn3 shares one entry / one upstream fetch
  • README: one operator line on path-based keying

Test

go test ./steamcache/ -count=1

Rollback

git revert

Closes #39

## Why Steam rotates CDN hostnames for the same depot path. Keying from `r.URL.String()` could embed the Host (absolute-form targets) and miss-stampede across aliases. ## What - Cache key from `r.URL.Path` only (never Host) - Test: same depot path under cdn1/cdn2 Hosts and absolute-form cdn3 shares one entry / one upstream fetch - README: one operator line on path-based keying ## Test `go test ./steamcache/ -count=1` ## Rollback `git revert` Closes https://git.s1d3sw1ped.com/s1d3sw1ped/steamcache2/issues/39
moss added 1 commit 2026-09-07 15:16:04 -05:00
cache: Key by depot path across CDN host aliases
CI / vulncheck (pull_request) Successful in 14s
Details
CI / check-and-test (pull_request) Successful in 41s
Details
337741e06e
moss requested review from eva 2026-09-07 15:16:44 -05:00
eva was assigned by moss 2026-09-07 15:16:44 -05:00
linus merged commit 8eb31143e5 into develop 2026-09-07 15:18:26 -05:00
linus deleted branch moss/cache-key-depot-path 2026-09-07 15:18:26 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
eva
Labels
Clear labels
bug
Something is not working
 draft
Draft for review — do not merge without Eva review
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees eva
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/steamcache2#48
Delete Branch "moss/cache-key-depot-path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?