s1d3sw1ped/SwipedModSwitcher
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 7 Packages Wiki Activity Actions

switch: Run the link tests on Windows again #48

Merged
linus merged 1 commit from ash/win-link-tests into develop 2026-10-24 17:24:18 +00:00
Conversation 2 Commits 1 Files changed 1 -14
ash commented 2026-10-24 17:21:56 +00:00
Collaborator
Copy link

Follow-up to #46. The win-runner forgejo-runner account can now create symlinks (ansible #108, runner restarted 12:11 PM CT), so this removes the requireSymlinks skip. The three link tests now run on the Windows job, and a missing privilege fails them instead of skipping them.

Follow-up to #46. The win-runner forgejo-runner account can now create symlinks (ansible #108, runner restarted 12:11 PM CT), so this removes the requireSymlinks skip. The three link tests now run on the Windows job, and a missing privilege fails them instead of skipping them.
switch: Run the link tests on Windows again
All checks were successful
CI / Build windows (pull_request) Successful in 10s
Details
CI / Build (pull_request) Successful in 47s
Details
CI / Lint (pull_request) Successful in 51s
Details
CI / Test (pull_request) Successful in 1m8s
Details
09eccd4bd1 
The win-runner account can now create symlinks (ansible #108), so the
skip added in #46 is no longer needed. A missing privilege now fails
the tests instead of hiding them.
ash requested review from eva 2026-10-24 17:21:56 +00:00
eva approved these changes 2026-10-24 17:23:53 +00:00
eva left a comment
Copy link

GO. Test-only change: it drops the requireSymlinks skip so the three link tests run on Windows again, and a missing symlink privilege now fails them instead of hiding them. Head 09eccd4 sits on the current develop tip, and CI on this head is green on all four jobs, including Build windows, so the tests ran and passed on the win-runner after ansible #108. The os import is still used, and lint agrees. Not security-sensitive, so Linus can merge.

GO. Test-only change: it drops the requireSymlinks skip so the three link tests run on Windows again, and a missing symlink privilege now fails them instead of hiding them. Head 09eccd4 sits on the current develop tip, and CI on this head is green on all four jobs, including Build windows, so the tests ran and passed on the win-runner after ansible #108. The os import is still used, and lint agrees. Not security-sensitive, so Linus can merge.
linus merged commit 9e04473bb4 into develop 2026-10-24 17:24:18 +00:00
linus deleted branch ash/win-link-tests 2026-10-24 17:24:18 +00:00
ash commented 2026-10-24 17:25:02 +00:00
Author
Collaborator
Copy link

CI run 175 at 09eccd4, job "Build windows" (win-runner), step "Test on windows", go test -v: the link tests ran, none skipped (0 --- SKIP lines).

--- PASS: TestSwitchLinkFailureLeavesOldLink (0.00s)
--- PASS: TestSwitchRealFolderIsNeverDeleted (0.00s)
--- PASS: TestSwitchEmptyPath (0.00s)
--- PASS: TestSwitchLinkToLink (0.00s)
ok  	s1d3sw1ped/swipedmodswitcher/switcher	0.018s

Log: https://git.s1d3sw1ped.com/s1d3sw1ped/SwipedModSwitcher/actions/runs/175/jobs/3/attempt/1

CI run 175 at 09eccd4, job "Build windows" (win-runner), step "Test on windows", `go test -v`: the link tests ran, none skipped (0 `--- SKIP` lines). ``` --- PASS: TestSwitchLinkFailureLeavesOldLink (0.00s) --- PASS: TestSwitchRealFolderIsNeverDeleted (0.00s) --- PASS: TestSwitchEmptyPath (0.00s) --- PASS: TestSwitchLinkToLink (0.00s) ok s1d3sw1ped/swipedmodswitcher/switcher 0.018s ``` Log: https://git.s1d3sw1ped.com/s1d3sw1ped/SwipedModSwitcher/actions/runs/175/jobs/3/attempt/1
Sign in to join this conversation.
Reviewers
No reviewers
eva
Labels
Clear labels   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
blocked
Stuck. The assignee needs a decision or an unblock; see the latest comment.

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
blocked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
s1d3sw1ped/SwipedModSwitcher!48
No description provided.