s1d3sw1ped/helix-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Persist per-install JWT signing secret #3

Merged
Ghost merged 1 commits from blake/jwt-secret-persist into master 2026-08-31 18:57:55 -05:00
Conversation 0 Commits 1 Files Changed 6
+106 -7
Ghost commented 2026-08-31 18:55:40 -05:00
Copy Link
Copy Source

Fixes #1

Stop signing admin JWTs with a compiled-in fallback secret. run now uses JWT_SECRET when set, otherwise a random per-install key in data/.jwt_secret (0600). Empty NewJWTManager("") uses a random in-memory secret so two processes no longer share a well-known key.

Not merged. Please review and merge if this looks right.

Fixes https://git.s1d3sw1ped.com/s1d3sw1ped/helix-proxy/issues/1 Stop signing admin JWTs with a compiled-in fallback secret. `run` now uses `JWT_SECRET` when set, otherwise a random per-install key in `data/.jwt_secret` (0600). Empty `NewJWTManager("")` uses a random in-memory secret so two processes no longer share a well-known key. Not merged. Please review and merge if this looks right.
Ghost added 1 commit 2026-08-31 18:55:41 -05:00
Persist a per-install JWT signing secret instead of a compiled-in default.
Format / gofmt (push) Successful in 8s
Details
Format / gofmt (pull_request) Successful in 9s
Details
CI / Build (push) Successful in 24s
Details
CI / Build (pull_request) Successful in 25s
Details
CI / Go Tests (pull_request) Successful in 39s
Details
CI / Go Tests (push) Successful in 40s
Details
22844a2a67 
Admin tokens were forgeable whenever JWT_SECRET was unset. Prefer the env var, otherwise write a random key to data/.jwt_secret.
Ghost merged commit a43217b459 into master 2026-08-31 18:57:55 -05:00
Ghost deleted branch blake/jwt-secret-persist 2026-08-31 18:57:55 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/helix-proxy#3
Delete Branch "blake/jwt-secret-persist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?