s1d3sw1ped/helix-proxy
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Persist per-install JWT signing secret #3

Merged
Ghost merged 1 commit from blake/jwt-secret-persist into master 2026-08-31 23:57:55 +00:00
Conversation 0 Commits 1 Files changed 6 +106 -7
Ghost commented 2026-08-31 23:55:40 +00:00
Copy link

Fixes #1

Stop signing admin JWTs with a compiled-in fallback secret. run now uses JWT_SECRET when set, otherwise a random per-install key in data/.jwt_secret (0600). Empty NewJWTManager("") uses a random in-memory secret so two processes no longer share a well-known key.

Not merged. Please review and merge if this looks right.

Fixes https://git.s1d3sw1ped.com/s1d3sw1ped/helix-proxy/issues/1 Stop signing admin JWTs with a compiled-in fallback secret. `run` now uses `JWT_SECRET` when set, otherwise a random per-install key in `data/.jwt_secret` (0600). Empty `NewJWTManager("")` uses a random in-memory secret so two processes no longer share a well-known key. Not merged. Please review and merge if this looks right.
Persist a per-install JWT signing secret instead of a compiled-in default.
All checks were successful
Format / gofmt (push) Successful in 8s
Details
Format / gofmt (pull_request) Successful in 9s
Details
CI / Build (push) Successful in 24s
Details
CI / Build (pull_request) Successful in 25s
Details
CI / Go Tests (pull_request) Successful in 39s
Details
CI / Go Tests (push) Successful in 40s
Details
22844a2a67 
Admin tokens were forgeable whenever JWT_SECRET was unset. Prefer the env var, otherwise write a random key to data/.jwt_secret.
Ghost merged commit a43217b459 into master 2026-08-31 23:57:55 +00:00
Ghost deleted branch blake/jwt-secret-persist 2026-08-31 23:57:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked
Stuck. The assignee needs a decision or an unblock; see the latest comment.

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
blocked
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
s1d3sw1ped/helix-proxy!3
No description provided.