s1d3sw1ped/robinhood-agentic-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client: Honor IsError and extract JSON from tool text #17

Closed
ash wants to merge 1 commits from client/tooljson-iserror into develop
pull from: client/tooljson-iserror
merge into: s1d3sw1ped:develop
Conversation 1 Commits 1 Files Changed 2
+72 -28
ash commented 2026-09-05 00:01:08 -05:00
Collaborator
Copy Link
Copy Source

What

Follow-up on #16 / closed #15 after Jerry dump arrived mid-flight.

  • IsError text is TrimSpaced (whitespace-only → tool error)
  • Prefer surfacing IsError text even when StructuredContent is present
  • rawJSON helper; try concatenated TextContent JSON before extract
  • Shape hint keeps types=[…] via %v; includes textLen
  • Unit tests mirror Jerry dump: IsError=true, StructuredContent=null, Text=end must be after start, GetError=nil

Why

Jerry dump: IsError=true, StructuredContent=null, Text=end must be after start, GetError=nil. Root paper time window remains tradey#2 (out of scope).

Test

go test ./... green

Notes

Do not merge until reviewed. Issue: #15

## What Follow-up on #16 / closed #15 after Jerry dump arrived mid-flight. - `IsError` text is `TrimSpace`d (whitespace-only → `tool error`) - Prefer surfacing `IsError` text even when `StructuredContent` is present - `rawJSON` helper; try concatenated TextContent JSON before extract - Shape hint keeps `types=[…]` via `%v`; includes `textLen` - Unit tests mirror Jerry dump: `IsError=true`, `StructuredContent=null`, Text=`end must be after start`, `GetError=nil` ## Why Jerry dump: IsError=true, StructuredContent=null, Text=`end must be after start`, GetError=nil. Root paper time window remains tradey#2 (out of scope). ## Test `go test ./...` green ## Notes Do not merge until reviewed. Issue: https://git.s1d3sw1ped.com/s1d3sw1ped/robinhood-agentic-mcp/issues/15
ash added 1 commit 2026-09-05 00:01:08 -05:00
client: Honor IsError and extract JSON from tool text
CI / Test and build (pull_request) Successful in 14s
Details
a6cede784a 
Fold Jerry dump into toolJSON: TrimSpace IsError text, concat JSON
via rawJSON, and unit tests mirroring IsError=true /
StructuredContent=null / Text=`end must be after start` / GetError=nil.
ash requested review from linus 2026-09-05 00:01:08 -05:00
ash commented 2026-09-05 00:01:43 -05:00
Author
Collaborator
Copy Link
Copy Source

Closing without merge — race leftover. #15 already landed as #16 (51e1539 on develop). Jerry-dump IsError path is covered there; minor TrimSpace/test nits not worth a second PR.

Closing without merge — race leftover. #15 already landed as #16 (51e1539 on develop). Jerry-dump IsError path is covered there; minor TrimSpace/test nits not worth a second PR.
ash closed this pull request 2026-09-05 00:01:43 -05:00
All checks were successful
CI / Test and build (pull_request) Successful in 14s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
linus
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/robinhood-agentic-mcp#17
Delete Branch "client/tooljson-iserror"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?