Merge pull request 'fix: trim query parameters from URL path in ServeHTTP to ensure cache key correctness' (#4 ) from fix/query-params into main

Reviewed-on: s1d3sw1ped/SteamCache2#4
fix: trim query parameters from URL path in ServeHTTP to ensure cache key correctness
2025-07-13 10:43:21 +00:00 · 2025-07-13 05:42:07 -05:00
1 changed files with 4 additions and 0 deletions
--- a/steamcache/steamcache.go
+++ b/steamcache/steamcache.go
@@ -218,6 +218,10 @@ func (sc *SteamCache) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	}

 	if strings.HasPrefix(r.URL.String(), "/depot/") {
+		// trim the query parameters from the URL path
+		// this is necessary because the cache key should not include query parameters
+		r.URL.Path = strings.Split(r.URL.Path, "?")[0]
+
 		tstart := time.Now()
 		defer func() { responseTime.Observe(time.Since(tstart).Seconds()) }()
Author	SHA1	Message	Date
s1d3sw1ped	7f744d04b0	Merge pull request 'fix: trim query parameters from URL path in ServeHTTP to ensure cache key correctness' (#4 ) from fix/query-params into main All checks were successful Release Tag / release (push) Successful in 17s Details Reviewed-on: s1d3sw1ped/SteamCache2#4	2025-07-13 10:43:21 +00:00
Justin Harms	6c98d03ae7	fix: trim query parameters from URL path in ServeHTTP to ensure cache key correctness All checks were successful PR Check / check-and-test (pull_request) Successful in 16s Details	2025-07-13 05:42:07 -05:00