s1d3sw1ped/steamcache2
1
0
Fork 0
Code Issues Pull requests Projects Releases 34 Packages Wiki Activity Actions

vfs/disk: Fix EvictDiskVisibilityAndRecreateSafety flake #19

Merged
Ghost merged 2 commits from fix/disk-evict-stat-race into develop 2026-09-01 20:21:06 +00:00
Conversation 0 Commits 2 Files changed 3 +92 -46
Ghost commented 2026-09-01 20:19:59 +00:00
Copy link

What

Make insertBatch fail-closed: re-stat under lock and skip gone files so bg population cannot resurrect keys after Evict/Delete. Tighten EvictDiskVisibility test (drain init via Size) and add InsertBatchSkipsGoneFiles. Optional: paths-ignore markdown on push to main.

Why

CI #1145 failed under -race -shuffle=on: Stat succeeded while the backing file was already gone. Create does not wait on initDone; the bg scan can discover files that eviction later removes, then insertBatch re-indexed the stale discovery.

Test

  • go test -race -count=20 -shuffle=on ./vfs/disk green locally
  • No LICENSE change

Fixes #18

## What Make `insertBatch` fail-closed: re-stat under lock and skip gone files so bg population cannot resurrect keys after Evict/Delete. Tighten EvictDiskVisibility test (drain init via Size) and add InsertBatchSkipsGoneFiles. Optional: paths-ignore markdown on push to main. ## Why CI #1145 failed under `-race -shuffle=on`: Stat succeeded while the backing file was already gone. Create does not wait on initDone; the bg scan can discover files that eviction later removes, then insertBatch re-indexed the stale discovery. ## Test - `go test -race -count=20 -shuffle=on ./vfs/disk` green locally - No LICENSE change Fixes #18 
New() launches background calculateSizeAndPopulateIndex which scans
disk and calls insertBatch. Create does not wait on initDone, so a
file can be written and indexed, discovered by the scan, then removed
from d.info and disk by EvictLRU/EvictBySize. insertBatch then
re-inserted the stale discoveredFile without checking the path still
existed, so Stat succeeded from the index while os.Stat failed.

Re-stat under the lock and skip gone files so evicted keys are not
resurrected.

Fixes #18.
ci: Skip test workflow on markdown-only pushes
All checks were successful
CI / vulncheck (pull_request) Successful in 14s
Details
CI / check-and-test (pull_request) Successful in 40s
Details
acd006d4a2 
Docs-only pushes to main (**.md / CONTRIBUTING.md) do not need the
full check-and-test job. Pull requests are unchanged.
Ghost merged commit 5d006ac44f into develop 2026-09-01 20:21:06 +00:00
Ghost deleted branch fix/disk-evict-stat-race 2026-09-01 20:21:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked
Stuck. The assignee needs a decision or an unblock; see the latest comment.

  
bug
Something is not working

  
draft
Draft for review — do not merge without Eva review

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
blocked
bug
draft
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
s1d3sw1ped/steamcache2!19
No description provided.