vfs/disk: Fix EvictDiskVisibilityAndRecreateSafety flake #20

Merged

Ghost merged 4 commits from develop into main 2026-09-01 15:23:10 -05:00

Conversation 0 Commits 4 Files Changed 4

+132 -46

Ghost commented 2026-09-01 15:21:07 -05:00

Copy Link

Copy Source

Promote #19 from develop to main so default tip keeps the durable vfs/disk fix and md paths-ignore.

Fixes #18 (already closed by #19 if so).

What/Why/Test: see #19. CI green on develop PR.

Promote #19 from develop to main so default tip keeps the durable vfs/disk fix and md paths-ignore. Fixes https://git.s1d3sw1ped.com/s1d3sw1ped/steamcache2/issues/18 (already closed by #19 if so). What/Why/Test: see #19. CI green on develop PR.

Ghost added 4 commits 2026-09-01 15:21:07 -05:00

docs: Add CONTRIBUTING.md ... 0198e8990b

Contributors need a short guide for develop-targeted PRs, commit
subject form, and Gitea issue-closing rules.

vfs/disk: Fix EvictDiskVisibilityAndRecreateSafety flake ... 30a695458e

New() launches background calculateSizeAndPopulateIndex which scans
disk and calls insertBatch. Create does not wait on initDone, so a
file can be written and indexed, discovered by the scan, then removed
from d.info and disk by EvictLRU/EvictBySize. insertBatch then
re-inserted the stale discoveredFile without checking the path still
existed, so Stat succeeded from the index while os.Stat failed.

Re-stat under the lock and skip gone files so evicted keys are not
resurrected.

Fixes #18.

ci: Skip test workflow on markdown-only pushes ... acd006d4a2

Docs-only pushes to main (**.md / CONTRIBUTING.md) do not need the
full check-and-test job. Pull requests are unchanged.

vfs/disk: Fix EvictDiskVisibilityAndRecreateSafety flake 5d006ac44f

Ghost merged commit a2ac13d317 into main 2026-09-01 15:23:10 -05:00

Ghost referenced this pull request 2026-09-01 15:25:05 -05:00

vfs/cache: Fix data race between memoryWriteCloser.Close and promoteToFast #22

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

draft

Draft for review — do not merge without Eva review

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ash blake eva linus moss pike s1d3sw1ped

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: s1d3sw1ped/steamcache2#20