Promote develop: vfs/cache promoteToFast race fix #24

Merged

Ghost merged 2 commits from develop into main 2026-09-01 15:36:49 -05:00

Conversation 0 Commits 2 Files Changed 6

+94 -8

Ghost commented 2026-09-01 15:35:56 -05:00

Copy Link

Copy Source

Promote #23 (Stat snapshots + promote size from len(content)) so main tip is race-clean.

#21

Promote #23 (Stat snapshots + promote size from len(content)) so main tip is race-clean. https://git.s1d3sw1ped.com/s1d3sw1ped/steamcache2/issues/21

Ghost added 2 commits 2026-09-01 15:35:56 -05:00

vfs/cache: Fix promoteToFast race with WriteCloser Close ... 8e09c89e24

promoteToFast read FileInfo.Size from Stat after the VFS lock was
released, while WriteCloser.Close updated Size on the same live
object. Concurrent Create/Open on overlapping keys tripped the race
detector.

Stat now returns a FileInfo snapshot, and promotion uses the
ReadAll length for the fast-tier Create size. Promotion stays
best-effort.

#21

Merge pull request 'vfs/cache: Fix promoteToFast race with WriteCloser Close' (#23) from vfs/cache-promote-race into develop ... 523a9a4782

Stat returns FileInfo snapshots; promoteToFast sizes from len(content).

#21

Ghost merged commit 04d1c6c368 into main 2026-09-01 15:36:49 -05:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

draft

Draft for review — do not merge without Eva review

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ash blake eva linus moss pike s1d3sw1ped

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: s1d3sw1ped/steamcache2#24