s1d3sw1ped/steamcache2
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 32 Wiki Activity

ops: Widen validate-check for upstream/write/rate failures #47

Merged
linus merged 1 commits from ops/validate-check-upstream-failures into develop 2026-09-07 14:53:37 -05:00
Conversation 0 Commits 1 Files Changed 2
+7 -6
pike commented 2026-09-07 14:52:02 -05:00
Collaborator
Copy Link
Copy Source

Why

make validate-check already answered "is it caching?" via hit/miss, but ignored upstream_errors / cache_write_failures / rate_limited, so a hot failure path could look fine when hits exist.

What

  • Widen the highlight grep in make validate-check to include those three fields
  • Document them in README Quick check (and a one-line note under Inspecting the Result)

Test

  • Inspected Makefile target + README Quick check table
  • Fields already emitted by /metrics (steamcache/metrics/metrics.go); no new metrics stack

Risks / rollback

Docs + Makefile only. Revert commit.

Closes #34

## Why `make validate-check` already answered "is it caching?" via hit/miss, but ignored `upstream_errors` / `cache_write_failures` / `rate_limited`, so a hot failure path could look fine when hits exist. ## What - Widen the highlight grep in `make validate-check` to include those three fields - Document them in README Quick check (and a one-line note under Inspecting the Result) ## Test - Inspected Makefile target + README Quick check table - Fields already emitted by `/metrics` (`steamcache/metrics/metrics.go`); no new metrics stack ## Risks / rollback Docs + Makefile only. Revert commit. Closes #34
pike added 1 commit 2026-09-07 14:52:02 -05:00
ops: Widen validate-check for upstream/write/rate failures
CI / vulncheck (pull_request) Successful in 15s
Details
CI / check-and-test (pull_request) Successful in 41s
Details
144a68dcd7 
Surface upstream_errors, cache_write_failures, and rate_limited in
make validate-check highlights and Quick check docs so a hot failure
path cannot look fine when hits exist.

Closes #34
pike requested review from eva 2026-09-07 14:52:02 -05:00
pike requested review from linus 2026-09-07 14:52:02 -05:00
linus merged commit 2c8ec276e7 into develop 2026-09-07 14:53:37 -05:00
linus deleted branch ops/validate-check-upstream-failures 2026-09-07 14:53:37 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
eva
linus
Labels
Clear labels
bug
Something is not working
 draft
Draft for review — do not merge without Eva review
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ash blake eva linus moss pike s1d3sw1ped
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: s1d3sw1ped/steamcache2#47
Delete Branch "ops/validate-check-upstream-failures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?