client: Honor IsError and extract JSON from tool text #16

2026-09-04T23:53:58-05:00

ash commented

2026-09-04 23:53:58 -05:00

What

Honor CallToolResult.IsError on the client and harden TextContent JSON extraction in toolJSON.

When IsError is set, surface TextContent as the tool error (not non-json tool result). GetError() stays for the server/SetError path but is always nil on clients (go-sdk v1.7.0).
Prefer StructuredContent when present (keep #14).
Else TextContent: try each alone for valid JSON; then concat; then extract first balanced {…} / […] (string/escape-aware).
On remaining failure, error includes shape summary: isError, content types, structured nil/present, textLen + ~80-rune prefix.

Why

CT113 tip 11feaad (#14) still fails: historicals: mcp get_equity_historicals: non-json tool result. StructuredContent prefer did not clear the live path → StructuredContent likely nil; TextContent non-JSON or IsError soft-fail that looked like non-json because GetError() is never set on clients.

Test

go test ./... green
New/updated: IsError+text (field, GetError nil), empty IsError → tool error, wrapped JSON in prose, one-of-many text JSON, array / brace-in-string extract, non-JSON with shape hint
Existing structured / text JSON / empty / nil / GetError kept

Issue: #15

Do not merge until Remy re-proves after deploy (paper only). Out of scope: live/place, knobs, lab SSH / CT113 from this PR.

## What Honor `CallToolResult.IsError` on the client and harden TextContent JSON extraction in `toolJSON`. 1. When `IsError` is set, surface TextContent as the tool error (not `non-json tool result`). `GetError()` stays for the server/SetError path but is always nil on clients (go-sdk v1.7.0). 2. Prefer `StructuredContent` when present (keep #14). 3. Else TextContent: try each alone for valid JSON; then concat; then extract first balanced `{…}` / `[…]` (string/escape-aware). 4. On remaining failure, error includes shape summary: isError, content types, structured nil/present, textLen + ~80-rune prefix. ## Why CT113 tip `11feaad` (#14) still fails: `historicals: mcp get_equity_historicals: non-json tool result`. StructuredContent prefer did not clear the live path → StructuredContent likely nil; TextContent non-JSON or IsError soft-fail that looked like non-json because `GetError()` is never set on clients. ## Test - `go test ./...` green - New/updated: IsError+text (field, GetError nil), empty IsError → `tool error`, wrapped JSON in prose, one-of-many text JSON, array / brace-in-string extract, non-JSON with shape hint - Existing structured / text JSON / empty / nil / GetError kept Issue: https://git.s1d3sw1ped.com/s1d3sw1ped/robinhood-agentic-mcp/issues/15 Do not merge until Remy re-proves after deploy (paper only). Out of scope: live/place, knobs, lab SSH / CT113 from this PR.

ash self-assigned this 2026-09-04 23:53:58 -05:00

ash added 1 commit 2026-09-04 23:53:58 -05:00

client: Honor IsError and extract JSON from tool text

CI / Test and build (pull_request) Successful in 13s

Details

66ec6305e8